This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Move __move_post_blt from object.d to core.internal.moving.d#2769
Merged
dlang-bot merged 1 commit intodlang:masterfrom Aug 28, 2019
JinShil:move_move
Merged
Move __move_post_blt from object.d to core.internal.moving.d#2769dlang-bot merged 1 commit intodlang:masterfrom JinShil:move_move
dlang-bot merged 1 commit intodlang:masterfrom
JinShil:move_move
Conversation
JinShil
requested review from
MartinNowak,
andralex,
schveiguy and
wilzbach
as code owners
Contributor
|
Thanks for your pull request and interest in making D better, @JinShil! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + druntime#2769" |
JinShil
changed the title
JinShil
changed the title
Contributor
Author
|
It appears code in Phobos calls this directly, so I reverted the rename. |
PetarKirov
approved these changes
Aug 28, 2019
This was referenced Aug 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #2647, #2644, #2643, #2634, #2763, #2765, and #2766
This is a continuation of work to clean up object.d.
This code was added in #2638, but it doesn't currently appear to be used anywhere.During the GSoC 2019 project for converting some runtime hooks to templates, we decided that we should be using the naming convention_d_whateverfor any runtime templates such as this. That naming convention is already the dominant convention in druntime, so it makes sense to keep it. It also distinguishes runtime hooks from compiler-generated symbols that are prefixed with__. A few of the templates don't follow the_d_convention, but I intend to remedy that with a later PR so all are consistent.